feat: implement sensitive operation audit retention (TASK-WP6-04)
Dada P0-A isolated Windows CI / validate-and-package (push) Failing after 59s

This commit is contained in:
suyx
2026-08-04 11:51:09 +08:00
parent c589b8bb4e
commit 1c46311e05
21 changed files with 1670 additions and 11 deletions
+148
View File
@@ -0,0 +1,148 @@
import type BetterSqlite3 from "better-sqlite3";
import type {
AdminAuditQuery,
AdminOperationAuditItem,
AdminOperationAuditResponse,
PrivateContentAccessAuditItem,
PrivateContentAccessAuditResponse,
} from "@dada/shared-contracts";
interface AuditCursor {
logId: string;
occurredAt: number;
}
interface AdminOperationRow {
actor_ref: string;
actor_type: "system" | "super_admin";
after_summary: string | null;
before_summary: string | null;
expires_at: number;
log_id: string;
occurred_at: number;
operation_type: string;
result: "failed" | "succeeded";
target_ref: string;
target_type: string;
}
interface PrivateContentAccessRow {
actor_ref: string;
content_type: "image" | "prompt";
expires_at: number;
log_id: string;
occurred_at: number;
target_ref: string;
}
export class AdminAuditQueryError extends Error {
constructor() {
super("admin_audit_query_invalid");
this.name = "AdminAuditQueryError";
}
}
function encodeCursor(row: { log_id: string; occurred_at: number }) {
return Buffer.from(JSON.stringify([row.occurred_at, row.log_id]), "utf8").toString("base64url");
}
function decodeCursor(cursor: string | undefined): AuditCursor | undefined {
if (!cursor) return undefined;
try {
const parsed: unknown = JSON.parse(Buffer.from(cursor, "base64url").toString("utf8"));
if (!Array.isArray(parsed) || parsed.length !== 2 || !Number.isSafeInteger(parsed[0])
|| typeof parsed[1] !== "string" || !/^[A-Za-z0-9][A-Za-z0-9_.:-]{0,159}$/.test(parsed[1])) {
throw new AdminAuditQueryError();
}
return { occurredAt: parsed[0] as number, logId: parsed[1] };
} catch (error) {
if (error instanceof AdminAuditQueryError) throw error;
throw new AdminAuditQueryError();
}
}
function normalizeLimit(limit: number | undefined) {
if (limit === undefined) return 50;
if (!Number.isSafeInteger(limit) || limit < 1 || limit > 100) throw new AdminAuditQueryError();
return limit;
}
function pageRows<Row extends { log_id: string; occurred_at: number }>(rows: Row[], limit: number) {
const hasMore = rows.length > limit;
const items = hasMore ? rows.slice(0, limit) : rows;
return { items, nextCursor: hasMore ? encodeCursor(items[items.length - 1]!) : null };
}
function iso(value: number) {
return new Date(value).toISOString();
}
export function listAdminOperationAudit(
database: BetterSqlite3.Database,
query: AdminAuditQuery,
clock: () => number = Date.now,
): AdminOperationAuditResponse {
const cursor = decodeCursor(query.cursor);
const limit = normalizeLimit(query.limit);
const rows = (cursor
? database.prepare(`
SELECT actor_ref, actor_type, after_summary, before_summary, expires_at, log_id,
occurred_at, operation_type, result, target_ref, target_type
FROM admin_operation_logs
WHERE occurred_at < ? OR (occurred_at = ? AND log_id < ?)
ORDER BY occurred_at DESC, log_id DESC LIMIT ?
`).all(cursor.occurredAt, cursor.occurredAt, cursor.logId, limit + 1)
: database.prepare(`
SELECT actor_ref, actor_type, after_summary, before_summary, expires_at, log_id,
occurred_at, operation_type, result, target_ref, target_type
FROM admin_operation_logs
ORDER BY occurred_at DESC, log_id DESC LIMIT ?
`).all(limit + 1)) as AdminOperationRow[];
const page = pageRows(rows, limit);
const items: AdminOperationAuditItem[] = page.items.map((row) => ({
actor_ref: row.actor_ref,
actor_type: row.actor_type,
after_summary: row.after_summary,
before_summary: row.before_summary,
expires_at: iso(row.expires_at),
log_id: row.log_id,
occurred_at: iso(row.occurred_at),
operation_type: row.operation_type,
result: row.result,
target_ref: row.target_ref,
target_type: row.target_type,
}));
return { generated_at: iso(clock()), items, next_cursor: page.nextCursor };
}
export function listPrivateContentAccessAudit(
database: BetterSqlite3.Database,
query: AdminAuditQuery,
clock: () => number = Date.now,
): PrivateContentAccessAuditResponse {
const cursor = decodeCursor(query.cursor);
const limit = normalizeLimit(query.limit);
const rows = (cursor
? database.prepare(`
SELECT actor_ref, content_type, expires_at, log_id, occurred_at, target_ref
FROM private_content_access_logs
WHERE occurred_at < ? OR (occurred_at = ? AND log_id < ?)
ORDER BY occurred_at DESC, log_id DESC LIMIT ?
`).all(cursor.occurredAt, cursor.occurredAt, cursor.logId, limit + 1)
: database.prepare(`
SELECT actor_ref, content_type, expires_at, log_id, occurred_at, target_ref
FROM private_content_access_logs
ORDER BY occurred_at DESC, log_id DESC LIMIT ?
`).all(limit + 1)) as PrivateContentAccessRow[];
const page = pageRows(rows, limit);
const items: PrivateContentAccessAuditItem[] = page.items.map((row) => ({
actor_ref: row.actor_ref,
content_type: row.content_type,
expires_at: iso(row.expires_at),
log_id: row.log_id,
occurred_at: iso(row.occurred_at),
target_ref: row.target_ref,
}));
return { generated_at: iso(clock()), items, next_cursor: page.nextCursor };
}
+80
View File
@@ -9,10 +9,13 @@ import {
AccountProfileUpdateRequestSchema,
AccountProfileUpdateResponseSchema,
AccountSettingsResponseSchema,
AdminAuditQuerySchema,
AdminAuthenticatedUserSchema,
AdminGenerationRecordSchema,
AdminGenerationListResponseSchema,
AdminOverviewResponseSchema,
AdminOperationAuditItemSchema,
AdminOperationAuditResponseSchema,
AdminServicesResponseSchema,
AdminServiceHealthCheckRequestSchema,
AdminServiceLimitRequestSchema,
@@ -78,6 +81,8 @@ import {
PrivateContentNoticeAckRequestSchema,
PrivateContentNoticeAckResponseSchema,
PrivateContentPromptResponseSchema,
PrivateContentAccessAuditItemSchema,
PrivateContentAccessAuditResponseSchema,
FailedEmptyTrashRequestSchema,
FailedEmptyTrashResponseSchema,
ExportFormatSchema,
@@ -129,6 +134,7 @@ import {
type AdminLoginCompleteRequest,
type AdminLoginSendRequest,
type AdminOverviewResponse,
type AdminAuditQuery,
type AdminDiagnosticsResponse,
type AdminServicesStorageResponse,
type AccountDeletionCompleteRequest,
@@ -195,6 +201,11 @@ import {
registrationFieldError,
} from "./registration-errors.js";
import type { RegistrationService } from "./registration.js";
import {
AdminAuditQueryError,
listAdminOperationAudit,
listPrivateContentAccessAudit,
} from "./admin-audit.js";
import type { AssetPreviewGrantService } from "./preview-grants.js";
import type { RecentAssetService } from "./recent-assets.js";
import type { AmapAdapter } from "./amap-adapter.js";
@@ -749,11 +760,16 @@ export async function createApp(options: CreateAppOptions = {}) {
AdminLoginCompleteRequestSchema,
AdminLoginCompleteResponseSchema,
AdminSessionResponseSchema,
AdminAuditQuerySchema,
AdminOperationAuditItemSchema,
AdminOperationAuditResponseSchema,
AdminGenerationRecordSchema,
AdminGenerationListResponseSchema,
PrivateContentNoticeAckRequestSchema,
PrivateContentNoticeAckResponseSchema,
PrivateContentPromptResponseSchema,
PrivateContentAccessAuditItemSchema,
PrivateContentAccessAuditResponseSchema,
PrivateContentGenerationParamsSchema,
AdminOverviewResponseSchema,
AdminServicesResponseSchema,
@@ -1684,6 +1700,70 @@ export async function createApp(options: CreateAppOptions = {}) {
},
);
app.get(
"/api/v1/admin/audit/operations",
{
schema: {
operationId: "getAdminOperationAudit",
querystring: Type.Ref(AdminAuditQuerySchema),
response: {
200: Type.Ref(AdminOperationAuditResponseSchema),
400: Type.Null(),
401: Type.Ref(ErrorEnvelopeSchema),
503: Type.Null(),
},
tags: ["Admin Operations"],
},
},
async (request, reply) => {
if (!options.registration) return reply.code(503).send(null);
const token = cookieValue(headerValue(request.headers.cookie), adminSessionCookieName);
const session = token ? options.registration.readAdminSession(token) : undefined;
if (!session) {
return reply.code(401).send(createErrorEnvelope({ code: "AUTH_SESSION_INVALID", correlationId: request.id }));
}
try {
reply.header("Cache-Control", "private, no-store");
return listAdminOperationAudit(options.registration.database, request.query as AdminAuditQuery);
} catch (error) {
if (error instanceof AdminAuditQueryError) return reply.code(400).send(null);
throw error;
}
},
);
app.get(
"/api/v1/admin/audit/private-content",
{
schema: {
operationId: "getPrivateContentAccessAudit",
querystring: Type.Ref(AdminAuditQuerySchema),
response: {
200: Type.Ref(PrivateContentAccessAuditResponseSchema),
400: Type.Null(),
401: Type.Ref(ErrorEnvelopeSchema),
503: Type.Null(),
},
tags: ["Admin Operations"],
},
},
async (request, reply) => {
if (!options.registration) return reply.code(503).send(null);
const token = cookieValue(headerValue(request.headers.cookie), adminSessionCookieName);
const session = token ? options.registration.readAdminSession(token) : undefined;
if (!session) {
return reply.code(401).send(createErrorEnvelope({ code: "AUTH_SESSION_INVALID", correlationId: request.id }));
}
try {
reply.header("Cache-Control", "private, no-store");
return listPrivateContentAccessAudit(options.registration.database, request.query as AdminAuditQuery);
} catch (error) {
if (error instanceof AdminAuditQueryError) return reply.code(400).send(null);
throw error;
}
},
);
app.get(
"/api/v1/admin/overview",
{
+57 -2
View File
@@ -4,6 +4,7 @@ import { createRequire } from "node:module";
import type BetterSqlite3 from "better-sqlite3";
import {
auditRetentionMilliseconds,
ensureAdminOperationAuditSchema,
ensurePrivateAccessAuditSchema,
isSafeAuditRef,
@@ -281,6 +282,39 @@ export class RegistrationService {
return { code, inviteId };
}
createAdminInvite(input: { actorId: string; expiresAt: number; maxUses: number }) {
if (!Number.isSafeInteger(input.expiresAt) || !Number.isSafeInteger(input.maxUses) || input.maxUses < 1) {
throw new Error("Invite request is invalid.");
}
const code = this.options.inviteCodeGenerator();
const inviteId = randomUUID();
const now = this.options.clock();
this.runImmediate("invite_create", () => {
const admin = this.database.prepare(`
SELECT u.user_id FROM users u JOIN admin_access a ON a.user_id = u.user_id
WHERE u.user_id = ? AND u.role = 'super_admin' AND u.status = 'active' AND a.allowed = 1
`).get(input.actorId);
if (!admin) throw new RegistrationError("AUTH_SESSION_INVALID", "session_invalid");
this.database.prepare(`
INSERT INTO invite_codes (
invite_id, code_hmac, max_uses, used_count, expires_at, status, created_at
) VALUES (?, ?, ?, 0, ?, 'enabled', ?)
`).run(inviteId, this.inviteHmac(code), input.maxUses, input.expiresAt, now);
this.recordAdminAudit({
actorRef: input.actorId,
actorType: "super_admin",
afterSummary: { max_uses: input.maxUses, status: "enabled" },
beforeSummary: null,
operationType: "invite_create",
result: "succeeded",
targetRef: inviteId,
targetType: "invite",
}, now);
return { outcome: "committed", value: undefined };
});
return { code, inviteId };
}
async sendRegistrationCode(input: { email: string; inviteCode: string }): Promise<RegistrationSendResult> {
const email = normalizeEmail(input.email);
const inviteCode = normalizeProfileValue(input.inviteCode, 160);
@@ -1241,14 +1275,35 @@ export class RegistrationService {
return outcome;
}
changeUserStatus(userId: string, status: "suspended" | "deleted") {
changeUserStatus(userId: string, status: "suspended" | "deleted", actorId?: string) {
const now = this.options.clock();
this.runImmediate("session_revoke", () => {
if (actorId) {
const admin = this.database.prepare(`
SELECT u.user_id FROM users u JOIN admin_access a ON a.user_id = u.user_id
WHERE u.user_id = ? AND u.role = 'super_admin' AND u.status = 'active' AND a.allowed = 1
`).get(actorId);
if (!admin) throw new RegistrationError("AUTH_SESSION_INVALID", "session_invalid");
}
const before = this.database.prepare("SELECT status FROM users WHERE user_id = ? AND role = 'user'")
.get(userId) as { status: "active" | "suspended" | "deleted" } | undefined;
const changed = this.database.prepare("UPDATE users SET status = ? WHERE user_id = ? AND role = 'user'")
.run(status, userId);
if (changed.changes !== 1) throw new RegistrationError("AUTH_SESSION_INVALID", "session_invalid");
this.database.prepare("UPDATE sessions SET revoked_at = ? WHERE user_id = ? AND revoked_at IS NULL")
.run(now, userId);
if (actorId) {
this.recordAdminAudit({
actorRef: actorId,
actorType: "super_admin",
afterSummary: { status },
beforeSummary: { status: before?.status ?? "unknown" },
operationType: "user_status_change",
result: "succeeded",
targetRef: userId,
targetType: "user_account",
}, now);
}
return { outcome: "committed", value: undefined };
});
}
@@ -1772,7 +1827,7 @@ export class RegistrationService {
serializeAuditSummary(input.beforeSummary),
serializeAuditSummary(input.afterSummary),
now,
now + 180 * 24 * 60 * 60 * 1_000,
now + auditRetentionMilliseconds,
);
}
+46
View File
@@ -9,6 +9,12 @@ import sharp, { type Metadata } from "sharp";
import type { StaticStickerCatalogItem } from "@dada/static-sticker-catalog";
import {
auditRetentionMilliseconds,
isSafeAuditRef,
isSafeAuditSummaryJson,
serializeAuditSummary,
} from "./audit-policy.js";
import { ManagedStorage, type StagedManagedFile } from "./managed-storage.js";
import { StickerReleaseError } from "./sticker-release-errors.js";
import { classifyCapacity } from "./storage-policy.js";
@@ -115,6 +121,12 @@ export class StickerReleaseService {
this.database.pragma("journal_mode = WAL");
this.database.pragma("foreign_keys = ON");
this.database.pragma("busy_timeout = 5000");
this.database.function("dada_audit_ref_is_safe", { deterministic: true }, isSafeAuditRef);
this.database.function("dada_audit_summary_is_safe", { deterministic: true }, isSafeAuditSummaryJson);
this.database.function("dada_allow_privacy_purge", { deterministic: false }, () => 0);
this.database.function("dada_privacy_purge_subject", { deterministic: false }, () => "");
this.database.function("dada_allow_retention_purge", { deterministic: false }, () => 0);
this.database.function("dada_retention_purge_now", { deterministic: false }, () => 0);
this.storage = input.storage;
this.migrate();
}
@@ -234,6 +246,13 @@ export class StickerReleaseService {
WHERE release_version = ? AND stable_id = ?
`).run((input.enabled ?? existing.enabled === 1) ? 1 : 0, part, order, version, input.stableId);
this.finalizeRelease(version, current, input.actorId);
this.insertReleaseAudit({
actorId: input.actorId,
afterSummary: { enabled: input.enabled ?? existing.enabled === 1, order, part, stable_id: input.stableId },
beforeSummary: { enabled: existing.enabled === 1, order: existing.order_index, part: existing.part, stable_id: input.stableId },
operationType: "sticker_release_update",
releaseVersion: version,
});
return version;
});
return { item: itemView(this.readItem(releaseVersion, input.stableId)!), release_version: releaseVersion };
@@ -342,9 +361,36 @@ export class StickerReleaseService {
VALUES (?, ?, ?, ?, ?, ?)
`).run(input.actorId, input.keyDigest, input.requestHash, releaseVersion, input.stableId, iso(this.clock()));
this.finalizeRelease(releaseVersion, previous, input.actorId);
this.insertReleaseAudit({
actorId: input.actorId,
afterSummary: { enabled: input.enabled, order: input.order, part: input.part, stable_id: input.stableId },
beforeSummary: previous ? { release_version: previous } : null,
operationType: "sticker_release_publish",
releaseVersion,
});
return releaseVersion;
}
private insertReleaseAudit(input: {
actorId: string;
afterSummary: Record<string, unknown>;
beforeSummary: Record<string, unknown> | null;
operationType: "sticker_release_publish" | "sticker_release_update";
releaseVersion: string;
}) {
const occurredAt = this.clock();
this.database.prepare(`
INSERT INTO admin_operation_logs (
log_id, actor_type, actor_ref, operation_type, target_type, target_ref,
result, before_summary, after_summary, occurred_at, expires_at
) VALUES (?, 'super_admin', ?, ?, 'sticker_release', ?, 'succeeded', ?, ?, ?, ?)
`).run(
randomUUID(), input.actorId, input.operationType, input.releaseVersion,
serializeAuditSummary(input.beforeSummary), serializeAuditSummary(input.afterSummary),
occurredAt, occurredAt + auditRetentionMilliseconds,
);
}
private finalizeRelease(releaseVersion: string, previous: string | null, actorId: string) {
const rows = this.database.prepare(`
SELECT stable_id, part, order_index, original_sha256, thumbnail_sha256, enabled